[
https://issues.apache.org/jira/browse/OFBIZ-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826930#comment-16826930 ]
Nicolas Malin commented on OFBIZ-10921:
---------------------------------------
I would tend to improve the patch with deprecated martialStatus like this :
{code:java}
- <field name="maritalStatus" type="indicator"></field>
+ <field name="oldMaritalStatus" type="indicator" col-name="MARITAL_STATUS"><description>Deprecated since branch release: use martialStatusEnumId</description></field>
+ <field name="maritalStatusEnumId" type="id"/>{code}
I think it's important to have a good relation between the attribute name and the value content.
> Marital Status not managed properly in Person entity
> ----------------------------------------------------
>
> Key: OFBIZ-10921
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10921> Project: OFBiz
> Issue Type: Improvement
> Components: party
> Affects Versions: Trunk
> Reporter: Suraj Khurana
> Assignee: Suraj Khurana
> Priority: Major
> Attachments: OFBIZ-10921.patch
>
>
> Currently, *maritalStatus* is managed as an indicator (Y/N) in *Person*
> entity. I think we can enhance it and make it derived from *Enumeration*
> pattern.
>
> *Classification of legal marital status*
>
> - 1 - Married (and not separated) ...
> - 2 - Widowed (including living common law) ...
> - 3 - Separated (and not Divorced) ...
> - 4 - Divorced (including living common law) ...
> - 5 - Single (including living common law)
> Please refer discussion over ML:
> [
https://markmail.org/message/5b33qm3osy76if24]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
