[jira] [Commented] (OFBIZ-10925) Wrong permission check in ProductScreens#FindProduct

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10925) Wrong permission check in ProductScreens#FindProduct

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818101#comment-16818101 ]

Dennis Balkir commented on OFBIZ-10925:
---------------------------------------

I just removed the permission service completely.
There was the service {{productGenericPermission}} which could have been used instead, but this one calls the simple-method {{checkProductRelatedPermission}}, which then check for the {{CATALOG}} permisson. Since this is already done in the {{CommonProductDecorator}} before, it would not make any sense to do this a sceond time.

> Wrong permission check in ProductScreens#FindProduct
> ----------------------------------------------------
>
>                 Key: OFBIZ-10925
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10925
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Dennis Balkir
>            Priority: Major
>         Attachments: OFBIZ-10925_ProductScreens.patch
>
>
> The permisson serviceĀ {{acctgAgreementPermissionCheck}} is used in the screen {{FindProduct}} in {{ProductScreens.xml}}. This doesn't really make sense, since there is no connection to the accounting application here.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)