[jira] [Commented] (OFBIZ-10933) Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827515#comment-16827515 ]

Jacques Le Roux commented on OFBIZ-10933:
-----------------------------------------

Hi Mathieu,

Not a big deal, with trunk HEAD I get these warnings:

{noformat}
> Task :compileTestJava
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:94: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(propsB, new PNode<>(), new PNode<>()),
                                    ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:94: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(propsB, new PNode<>(), new PNode<>()),
                                                   ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:95: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<Object,Object>[]
                new PNode<>(new PNode<>()),
                            ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:94: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(propsB, new PNode<>(), new PNode<>()),
                                                   ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:94: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(propsB, new PNode<>(), new PNode<>()),
                                    ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:95: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(new PNode<>()),
                            ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:95: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(new PNode<>()),
                ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:96: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>());
                ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:94: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(propsB, new PNode<>(), new PNode<>()),
                ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:94: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(propsB, new PNode<>(), new PNode<>()),
                                    ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:94: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(propsB, new PNode<>(), new PNode<>()),
                                                   ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:95: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<Object,Object>[]
                new PNode<>(new PNode<>()),
                            ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:94: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(propsB, new PNode<>(), new PNode<>()),
                                    ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:94: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(propsB, new PNode<>(), new PNode<>()),
                                                   ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:96: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>());
                ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:95: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(new PNode<>()),
                            ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:94: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(propsB, new PNode<>(), new PNode<>()),
                ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:95: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
                new PNode<>(new PNode<>()),
                ^
C:\projectsASF\ofbiz\framework\base\src\test\java\org\apache\ofbiz\base\util\collections\MapContextTest.java:93: warning: [unchecked] unchecked generic array creation for varargs parameter of type PNode<String,String>[]
        PNode<String, String> pn = new PNode<>(propsA,
{noformat}

> Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-10933
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10933
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 18.12
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Major
>             Fix For: Trunk, Release Branch 18.12
>
>         Attachments: OFBIZ-10933_0001-Improved-Add-UtilMisc-toMap-Supplier-Map-K-V-Object.patch, OFBIZ-10933_0002-Fixed-Ensure-that-MapContext-preserves-insertion-ord.patch
>
>
> Since revision 1837462, when pushing a ‘LinkedHashMap’ inside a ‘MapContext’, the iteration order of the ‘MapContext’ values is not corresponding to the
> insertion order of the embedded ‘LinkedHashMap’ which is important in the ‘ControllerConfig’ case where configuration elements are stored in ‘LinkedHashMap’ objects and the ‘include’ mechanism relies on ‘MapContext’.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)