[
https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033511#comment-17033511 ]
Pierre Smits commented on OFBIZ-10934:
--------------------------------------
It is a pity that this issue has been closed with the 'Won't Do' resolution, just because a contributor could not find the time to take it further.
Based on what I understand from comments posted there is no reason not to implement the improvement. IMO, designating a ticket as 'trivial' doesn't help attracting fellow community members to work on it, especially when it involves more than real trivial issues like correcting typos.
> Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance
> ------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-10934
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10934> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: bd2019us
> Priority: Trivial
> Labels: performance
> Attachments: OFBIZ-10934.patch, OFBIZ10934-MORE.patch, affected_files
>
>
> Affected files:
> # framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
> # framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
> # framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java
> # framework/base/src/main/java/org/apache/ofbiz/base/util/KeyStoreUtil.java
> When replaceAll() is utilized and no regex is used, replaceAll() can be replaced with replace() for better performance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
