[
https://issues.apache.org/jira/browse/OFBIZ-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053405#comment-17053405 ]
Pierre Smits commented on OFBIZ-10948:
--------------------------------------
Hi [~priya.sharma.9362],
I tested your PR in a newly established test branch locally. It gave no error while:
# incorporating it in the codebase of the branch
# running the dwh initialisation
I checked various dimensions available through web tools, and these got data loaded.
So far so good!
A few remarks on the side though: as you didn't mention the OFBIZ issue ID (OFBIZ-10948) in the subject of the PR the backend GitHub services didn't update the ticket with a link to the PR. And your commit message also doesn't reference this ticket.
When future actions are executed on the PR, such as merging it into the code base, this ticket will not:
# show the merge details, or
# show comments made on the pr.
The above notwithstanding, I suggest to have this merged.
> Convert DimensionServices.xml minilang to groovy
> ------------------------------------------------
>
> Key: OFBIZ-10948
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10948> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Assignee: Pierre Smits
> Priority: Major
> Labels: Minilang, dimension, dwh, groovy,
> Attachments: OFBIZ-10948.patch
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, convert DimensionServices.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
