[
https://issues.apache.org/jira/browse/OFBIZ-10956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042587#comment-17042587 ]
Pierre Smits commented on OFBIZ-10956:
--------------------------------------
HI [~ankit.joshi],
Thank you for your time to review.
Re: *getDimensionRecord*
Thank you for bringing this to the attention. I will address this.
Re: *misalignment* between entity def for CountryDimension and the LoadCountryDimension method to populate
This mixup is the result of having multiple dev setups. Rewalking my steps taken, I originally intended to have following entity-model in play:
{code:java}
<entity entity-name="CountryDimension" package-name="org.ofbiz.bi.dimension" title="Countries Dimension">
<description>Dimension of countries. The natural key is [countryId]</description>
<field name="dimensionId" type="id">
<description>Unique identifier of the dimension record</description>
</field>
<field name="countryId" type="id">
<description>The country id (natural key). The ISO 3166-1 alpha-3 code of the Country</description>
</field>
<field name="countryCode" type="short-varchar">
<description>The ISO 3166-1 alpha-2 code of the Country</description>
</field>
<field name="countryNumCode" type="short-varchar">
<description>The ISO 3166-1 numeric code of the Country</description>
</field>
<field name="countryName" type="description">
<description>The name of the Country</description>
</field>
<field name="countryTeleCode" type="short-varchar">
<description>The country calling code of the Country</description>
</field>
<field name="tld" type="short-varchar">
<description>The country code top-level domain of the Country</description>
</field>
<field name="description" type="description">
<description>description of the record</description>
</field>
<prim-key field="dimensionId"/>
</entity>
{code}
which aligns with the method submitted in PR4. I would rather see the entityDef align to the method (with the entity definition as stated above) than the other way around, given that the field names more align to the intent of the dimension (as captured in the entity name.
We can easily change this now, since implementation of the entity definition has had no impact yet on upstream implementation as
* there is no release (branch) that has this entity def
* there is no service in play yet to populate the entity
re: Missing *Geo.GeoSecCode* reference in entity definition. See aspect about misalignment above. With revised entity definition this will be avoided, as the
{code:java}
newEntity.countryNumCode = country.geoSecCode;
{code}
will ensure that the Numeric Country Code will end in the entity.
I will provide an update via Github.
> Have a service to load records in the CountryDimension
> ------------------------------------------------------
>
> Key: OFBIZ-10956
> URL:
https://issues.apache.org/jira/browse/OFBIZ-10956> Project: OFBiz
> Issue Type: Improvement
> Components: bi
> Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
> Reporter: Pierre Smits
> Assignee: Ankit Joshi
> Priority: Major
> Labels: CountryDimension, birt, country, dimension, dwh, service
> Attachments: OFBIZ-10956.patch
>
>
> Depending on [OFBIZ-10954|
https://issues.apache.org/jira/browse/OFBIZ-10954]
> The service should be invoked on initialisation of the data warehouse.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
