[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168846#comment-17168846 ]

Jacques Le Roux commented on OFBIZ-10973:
-----------------------------------------

Could we not have sms in the name, to clearly shows that it's for sending SMS... something like sms-msg91...?

> Rename custom component for SMS gateway integration
> ---------------------------------------------------
>
>                 Key: OFBIZ-10973
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10973
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Pritam Kute
>            Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send sms".
> But could we not have another name, more explicit, for this component, like sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not associate the name of an open source component to a commercial services  provider (with a free SMS quota option). Even if hopefully it will stay as is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)