[
https://issues.apache.org/jira/browse/OFBIZ-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831021#comment-16831021 ]
Mathieu Lirzin commented on OFBIZ-11004:
----------------------------------------
This is not a bug fix since I didn't observe any undesired behavior, but to be safe I think I is a good idea to backport this patch to releases branches. What do people think?
> Add missing ‘synchronized’ modifier
> -----------------------------------
>
> Key: OFBIZ-11004
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11004> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Mathieu Lirzin
> Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11004_Add-missing-synchronized-modifier.patch
>
>
> Overidding a synchronized method with a non-synchronized one can
> introduce potential runtime concurrency bugs. Since
> ‘ExtendedProperties#loadFromXML’ is overridding
> ‘Propertiers#loadFromXML’ which is synchronized, it is safer to mark
> it as synchonized.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
