[jira] [Commented] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840423#comment-16840423 ]

Jacques Le Roux commented on OFBIZ-11021:
-----------------------------------------

+1 sounds good to  me.

Thanks Pawan, well spotted and fixed, but would be easier for reviewers if you explained in a sentence or two what you did in your patch in functional terms ;)

> The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-11021
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11021
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Trunk, Release Branch 18.12
>            Reporter: Pawan Verma
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-11021.patch
>
>
> The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart.
>   
>  Suppose we have two items in the cart:
>  # The first item is drop-shippable.
>  # The second item is not drop-shippable.
> For the first item, the implementation works fine.
>  For the second item, this is not working correctly.
>   
>  For drop shipment process, cart method 'createDropShipGroups' decides RequirementMethodEnumId in the order of property set at ProductStore -> ProductFacility -> Product which work fine in case of all drop-ship products and if the drop-ship product(s) is added last in the cart.
>   
>  The issue I found is that if a combination of a dropship and non-drop ship products are added into the cart and the non-drop shippable product(s) is added after the drop shippable product(s) then the non-drop-shippable products also considered as drop-shippable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)