[
https://issues.apache.org/jira/browse/OFBIZ-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16915564#comment-16915564 ]
Pierre Smits commented on OFBIZ-11024:
--------------------------------------
Hi [~rohit.hukkeri],
I have reviewed your patch, and tested it in a local test environment (see [1]). In both test setups the provided patch performed in accordance with expectations.
One minor observation: you're using the term 'LookupSupplierName'. I guess this is inline with other variants, but it is not about looking up the name of the supplier, but just the appropriate supplier(s) using a.o. names. Hence a better solution would be to use just LookupSupplier (e.g. to remove potential confusion).
[1] tests
* against trunk
* against r17.12
> Purchase Invoice creation should be limited for parties with roleTypeId = SUPPLIER
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-11024
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11024> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, Release Branch 18.12
> Reporter: Pierre Smits
> Assignee: Rohit Hukkeri
> Priority: Major
> Labels: invoice, purchase, supplier
> Attachments: OFBIZ_11024.patch
>
>
> Currently in the invoice creation process in accounting regarding purchase invoices, all parties can be selected as the invoice from party. This should be limited to parties with roleTypeId=SUPPLIER
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
Locked
