[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046616#comment-17046616 ]
Pierre Smits commented on OFBIZ-11030:
--------------------------------------
[~sberg]
Applying the patch gave following in a window in my git client (SourceTree)
{code:java}
git --no-optional-locks -c color.branch=false -c color.diff=false -c color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c credential.helper=sourcetree apply -v --reject -p 1 /Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:79: trailing whitespace.
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:107: trailing whitespace.
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:123: trailing whitespace.
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:139: trailing whitespace.
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:153: trailing whitespace.
Checking patch bi/groovyScripts/FactServices.groovy...
Checking patch bi/minilang/FactServices.xml...
Checking patch bi/servicedef/services.xml...
Applied patch bi/groovyScripts/FactServices.groovy cleanly.
Applied patch bi/minilang/FactServices.xml cleanly.
Applied patch bi/servicedef/services.xml cleanly.
warning: squelched 49 whitespace errors
warning: 54 lines add whitespace errors.
Completed successfully
{code}
Apart from that, loadInventoryFact() now delivered an acceptable result in a test.
> Convert FactServices.xml minilang to groovy
> -------------------------------------------
>
> Key: OFBIZ-11030
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11030> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Assignee: Sebastian Berg
> Priority: Major
> Labels: Fact, dwh, services
> Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-InventoryItemFact-DemoTrunk.png, OFBIZ-11030-InventoryItemFact-test.png, OFBIZ-11030-Order-SalesOrder-overview.png, OFBIZ-11030-SalesInvoiceItemFact-test.png, OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
