[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049196#comment-17049196 ]

Pierre Smits commented on OFBIZ-11030:
--------------------------------------

I got this again when trying to apply your patch in my git client (SourceTree):
{code:java}
git --no-optional-locks -c color.branch=false -c color.diff=false -c color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c credential.helper=sourcetree apply -v --reject -p 1 /Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-4.patch
error: corrupt patch at line 1530
Completed with errors, see above
{code}

> Convert FactServices.xml minilang to groovy
> -------------------------------------------
>
>                 Key: OFBIZ-11030
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11030
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: bi
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Sebastian Berg
>            Priority: Major
>              Labels: Fact, dwh, services
>         Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, OFBIZ-11030-InventoryItemFact-DemoTrunk.png, OFBIZ-11030-InventoryItemFact-test.png, OFBIZ-11030-Order-SalesOrder-overview.png, OFBIZ-11030-SalesInvoiceItemFact-test.png, OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350,  convert FactServices.xml

--
This message was sent by Atlassian Jira
(v8.3.4#803005)