[
https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840173#comment-16840173 ]
Girish Vasmatkar commented on OFBIZ-11032:
------------------------------------------
Hi Mathieu,
With these changes we might as well mark the class final. Would you agree?
Best,
Girish
> ServiceDispatcher implementation details should be private
> ----------------------------------------------------------
>
> Key: OFBIZ-11032
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11032> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Mathieu Lirzin
> Priority: Minor
> Attachments: OFBIZ-11032_ServiceDispatcher-is-not-meant-to-be-extend.patch
>
>
> The {{protected}} modifier is used for the ServiceDispatcher in place of {{private}}. Since the {{ServiceDispatcher}} is not meant to be extended by plugins it is not desirable to use the {{protected}} modifier.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
