[jira] Commented: (OFBIZ-111) Using hardwired /images instead of <@ofbizContentUrl> in .ftl files

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469511 ]

Chris Howe commented on OFBIZ-111:
----------------------------------

Thanks for getting to this Jacques!

Would it be possible for you to reopen this issue as the search and replace doesn't take care of the images set by variable.  The additionalContent.patch took care of those except that the patch is set from an absolute path and also the time separation probably will make chunk errors.  I'll try to resubmit a patch this weekend covering those if no one gets to it  by then.  Thanks!

> Using hardwired /images instead of <@ofbizContentUrl> in .ftl files
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-111
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-111
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: content, ecommerce, manufacturing, order, party, product
>    Affects Versions: SVN trunk
>            Reporter: Eriks Dobelis
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>         Attachments: additionalContentUrl.patch, contentUrl.patch
>
>
> There are some template and script files which use hardwired links, e.g. /images. This means that ofbizContentUrl is not taken into account and may not work if some components (especially images) are mounted at different locations.
> For ftl files <@ofbizContentUrl> should be used. I have no good idea what to do with javascript and css files.
> This is a list of files created by grep (grepping "\"/images" ) from application directory, which probably should be fixed.
> content/webapp/content/images/composite.js
> ecommerce/webapp/ecommerce/shoppinglist/editShoppingList.ftl
> ecommerce/webapp/ecommerce/cart/showcart.ftl
> ecommerce/webapp/ecommerce/includes/header.ftl
> ecommerce/webapp/ecommerce/order/splitship.ftl
> manufacturing/webapp/manufacturing/routing/EditRoutingTaskAssoc.ftl
> manufacturing/webapp/manufacturing/jobshopmgt/CreateProductionRun.ftl
> manufacturing/webapp/manufacturing/bom/EditProductBom.ftl
> order/webapp/ordermgr/entry/cart/showcartitems.ftl
> order/webapp/ordermgr/entry/cart/showcart.ftl
> order/webapp/ordermgr/entry/catalog/productsummary.ftl
> order/webapp/ordermgr/entry/catalog/productdetail.ftl
> order/webapp/ordermgr/entry/catalog/configproductdetail.ftl
> order/webapp/ordermgr/order/appendorderitem.ftl
> party/webapp/partymgr/party/EditPartyRelationships.ftl
> product/webapp/facility/returns/receiveReturn.ftl
> product/webapp/facility/facility/FindFacilityLocation.ftl
> product/webapp/facility/facility/EditFacilityGroups.ftl
> product/webapp/facility/shipment/QuickShipOrder.ftl
> product/webapp/facility/shipment/FindShipment.ftl
> product/webapp/facility/group/EditFacilityGroupMembers.ftl
> product/webapp/facility/group/EditFacilityGroupRollup.ftl
> product/webapp/facility/inventory/receiveInventory.ftl
> product/webapp/facility/inventory/TransferInventoryItem.ftl
> product/webapp/facility/inventory/EditInventoryItem.ftl
> product/webapp/catalog/product/EditProductQuickAdmin.ftl
> product/webapp/catalog/product/ApplyFeaturesFromCategory.ftl
> product/webapp/catalog/product/EditProductAssoc.ftl
> product/webapp/catalog/product/EditProductFeatures.ftl
> product/webapp/catalog/product/EditProductFacilityLocations.ftl
> product/webapp/catalog/find/keywordsearch.ftl
> product/webapp/catalog/promo/EditProductPromoStores.ftl
> product/webapp/catalog/store/EditProductStorePromos.ftl
> product/webapp/catalog/store/EditProductStoreSurveys.ftl
> product/webapp/catalog/category/EditCategoryProducts.ftl
> product/webapp/catalog/category/EditCategoryParties.ftl
> product/webapp/catalog/category/EditCategoryRollup.ftl
> product/webapp/catalog/category/EditCategoryProdCatalogs.ftl
> product/webapp/catalog/category/EditCategoryFeatureCats.ftl

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.