[jira] [Commented] (OFBIZ-11138) Refactor UtilHttp

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884628#comment-16884628 ]

Mathieu Lirzin commented on OFBIZ-11138:
----------------------------------------

Thanks Jacques,

Indeed, beside Java 11 HTTP client one possible enhancement that is available right now is the built-in support for multi-part/form since Servlet 3.0 which make Apache Commons FileUpload useless. removing this unnecessary dependency would be great.

Regarding  [^OFBIZ-11138.patch] , I have detected a failing integration test which is caused by the rewrite of {{getPathInfoOnlyParameterMap}}

{code}
2019-07-13 23:35:34,726 |main                 |TestRunContainer              |I| [JUNIT] Results for test suite: shoppingcarttests
2019-07-13 23:35:34,726 |main                 |TestRunContainer              |I| [JUNIT] Pass: false | # Tests: 6 | # Failed: 1 # Errors: 0
2019-07-13 23:35:34,726 |main                 |TestRunContainer              |I| [JUNIT] ----------------------------- ERRORS ----------------------------- [JUNIT]
2019-07-13 23:35:34,726 |main                 |TestRunContainer              |I| None
2019-07-13 23:35:34,726 |main                 |TestRunContainer              |I| [JUNIT] ------------------------------------------------------------------ [JUNIT]
2019-07-13 23:35:34,726 |main                 |TestRunContainer              |I| [JUNIT] ---------------------------- FAILURES ---------------------------- [JUNIT]
2019-07-13 23:35:34,726 |main                 |TestRunContainer              |I| --> configurableServiceOrder-test(org.apache.ofbiz.testtools.SimpleMethodTest): Error running the simple-method: java.lang.reflect.InvocationTargetException (null) Method = testCreateOrderConfigurableServiceProduct, File = file:/home/mthl/src/ofbiz/applications/order/minilang/test/ShoppingCartTests.xml, Element = <call-class-method>, Line 641null
2019-07-13 23:35:34,726 |main                 |TestRunContainer              |I| junit.framework.AssertionFailedError: Error running the simple-method: java.lang.reflect.InvocationTargetException (null) Method = testCreateOrderConfigurableServiceProduct, File = file:/home/mthl/src/ofbiz/applications/order/minilang/test/ShoppingCartTests.xml, Element = <call-class-method>, Line 641null
        at org.apache.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:91)
        at junit.framework.TestSuite.runTest(TestSuite.java:252)
        at junit.framework.TestSuite.run(TestSuite.java:247)
        at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
        at org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:156)
        at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:78)
        at org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:183)
        at org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:76)
        at org.apache.ofbiz.base.start.Start.main(Start.java:87)
{code}

I am still trying to understand the issue.

> Refactor UtilHttp
> -----------------
>
>                 Key: OFBIZ-11138
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11138
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>         Attachments: OFBIZ-11138.patch
>
>
> The handling of parameters map is using obsolete Java API like {{Enumeration}} with low-level data transformation.

--
This message was sent by Atlassian JIRA
(v7.6.14#76016)