[jira] [Commented] (OFBIZ-11164) Convert CommunicationEventServices.xml mini lang to groovy

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914532#comment-16914532 ]

Mathieu Lirzin commented on OFBIZ-11164:
----------------------------------------

{code:groovy}
        fieldsMap.partyIdTo = partyContactMech ?
                partyContactMech.partyId: null
{code}

{code:groovy}
createCommEventRoleMap.contactMechPurposeTypeIdFrom = parameters.contactMechPurposeTypeIdFrom?:""
{code}

Nitpick: There are missing spaces :-)

Even if this can be cumbersome to do, I will recommend separating the migration of individual services in individual commits to allow {{git bisect}} to do better job at detecting possible regressions.

Otherwise LGTM

> Convert CommunicationEventServices.xml mini lang to groovy
> ----------------------------------------------------------
>
>                 Key: OFBIZ-11164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11164
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: party
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Minor
>         Attachments: OFBIZ-11164.patch
>
>

--
This message was sent by Atlassian Jira
(v8.3.2#803003)