[jira] [Commented] (OFBIZ-11181) paymentMethodId choices wrong in form for creating/editing a received payment

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921457#comment-16921457 ]

Jacques Le Roux commented on OFBIZ-11181:
-----------------------------------------

Thanks Parminder,

Indeed, the drop down Payment method fields are the same in both cases. The values are retrieved from PaymentMethod entities (data) where the partyId=defaultOrganizationPartyId (OOTB "Company"). We would need to use something else for In Payment. We can refer to a Party, it would get complicated. So we need to introduce another mean to differentiate these IN payment methods. OOTB we could use the PaymentMethodType entities in AccountingSeedData.xml even if some are maybe not fitting well. At least most would make sense and customised project could add their own filters. Here they are:

{code:xml}
    <PaymentMethodType description="Credit Card" paymentMethodTypeId="CREDIT_CARD"/>
    <PaymentMethodType description="Gift Card" paymentMethodTypeId="GIFT_CARD"/>
    <PaymentMethodType description="Gift Certificate" paymentMethodTypeId="GIFT_CERTIFICATE"/>
    <PaymentMethodType description="Cash" paymentMethodTypeId="CASH"/>
    <PaymentMethodType description="Electronic Funds Transfer" paymentMethodTypeId="EFT_ACCOUNT"/>
    <PaymentMethodType description="Financial Account" paymentMethodTypeId="FIN_ACCOUNT"/>
    <PaymentMethodType description="Personal Check" paymentMethodTypeId="PERSONAL_CHECK"/>
    <PaymentMethodType description="Company Check" paymentMethodTypeId="COMPANY_CHECK"/>
    <PaymentMethodType description="Certified Check" paymentMethodTypeId="CERTIFIED_CHECK"/>
    <PaymentMethodType description="Money Order" paymentMethodTypeId="MONEY_ORDER"/>
    <PaymentMethodType description="Company Account" paymentMethodTypeId="COMPANY_ACCOUNT"/>
    <PaymentMethodType description="Billing Account" paymentMethodTypeId="EXT_BILLACT"/>
    <PaymentMethodType description="Cash On Delivery" paymentMethodTypeId="EXT_COD"/>
    <PaymentMethodType description="eBay" paymentMethodTypeId="EXT_EBAY"/>
    <PaymentMethodType description="Offline Payment" paymentMethodTypeId="EXT_OFFLINE"/>
    <PaymentMethodType description="PayPal" paymentMethodTypeId="EXT_PAYPAL"/>
    <PaymentMethodType description="RBS WorldPay" paymentMethodTypeId="EXT_WORLDPAY"/>
{code}

What do you think?

> paymentMethodId choices wrong in form for creating/editing a received payment
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-11181
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11181
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, Release Branch 18.12
>         Environment: Ofbiz 16.11.05 on Fedora 30 with OpenJDK 64-Bit Server VM (build 25.222-b10, mixed mode) and mariadb-server.x86_64 3:10.3.17-1.fc30 as database
>            Reporter: Parminder
>            Assignee: Jacques Le Roux
>            Priority: Major
>
> {color:#737373}There is a bug in the forms   for Payment{color}{color:#737373} method field(drop down) for Incoming payment. Payment methods should be{color}
> {color:#737373} whatever is  defined for getting the payments from customers like  {color}{color:#737373}Company Check, Cash etc. etc. but it is showing the methods which are{color}{color:#737373} applicable for outgoing payments such as Petty cash and defined{color}{color:#737373} Financial accounts (from where you pay the suppliers).{color}

--
This message was sent by Atlassian Jira
(v8.3.2#803003)