[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950278#comment-16950278 ]

Jacques Le Roux commented on OFBIZ-11229:
-----------------------------------------

Thanks Nicolas

Your patch is in
trunk r1868395
R18 r1868396
R17 r1868397

R16 is harder  to backport I gave up.

I wondered about duplicating convertToString(). But since the idea is to replace OfbizUrlTransform by UrlRegexpTransform it's not a problem.

Note: I only created this issue as a bug because OFBIZ-4361 depends on it. Else it would be an improvement.


> Merge UrlRegexpTransform and OfbizUrlTransform classes
> ------------------------------------------------------
>
>                 Key: OFBIZ-11229
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11229
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework, product
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch
>
>
> This improvemnt follows Paul's suggestion and this discussion which contains other references:
> https://markmail.org/message/bobj2uhnkzjddrtt.
> Globally can be summarised by my comment in this thread:
> bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used it everywhere. Now there are maybe few features in OfbizUrlTransform that are not in UrlRegexpTransform. That needs to be checked. If we can merge OfbizUrlTransform in UrlRegexpTransform then the later could be used everywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)