[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037507#comment-17037507 ]

ASF subversion and git services commented on OFBIZ-11229:
---------------------------------------------------------

Commit 969f48b7c9f692b8a6f1c54e2b4ce6ae1392961b in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=969f48b ]

Fixed: Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
(OFBIZ-11317)

In some place, like at least themes/tomahawk/template/AppBarClose.ftl the CSRF
token is not generated. Because in those places OfbizUrlTransform is used.

An immediate solution is to add the CSRF token generation in OfbizUrlTransform
class.

A definitive solution is to complete OFBIZ-11229
"Merge UrlRegexpTransform and OfbizUrlTransform classes"


> Merge UrlRegexpTransform and OfbizUrlTransform classes
> ------------------------------------------------------
>
>                 Key: OFBIZ-11229
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11229
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework, product
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch
>
>
> This improvemnt follows Paul's suggestion and this discussion which contains other references:
> https://markmail.org/message/bobj2uhnkzjddrtt.
> Globally can be summarised by my comment in this thread:
> bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used it everywhere. Now there are maybe few features in OfbizUrlTransform that are not in UrlRegexpTransform. That needs to be checked. If we can merge OfbizUrlTransform in UrlRegexpTransform then the later could be used everywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)