[jira] [Commented] (OFBIZ-11236) Add shipment notes

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028438#comment-17028438 ]

Jacques Le Roux commented on OFBIZ-11236:
-----------------------------------------

Hi Pierre,

Thanks for your patch, I reviewed it, looks good to me. I loaded the entities, tested, it seems to work for creating a note:

{noformat}
2020-02-02 14:26:51,116 |jsse-nio-8443-exec-3 |ServerHitBin                  |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-02-02 14:26:51,117 |jsse-nio-8443-exec-3 |ControlServlet                |T| [[[facility::ViewShipment (Domain:https://localhost)] Request Done- total:2.203,since last([facility::ViewSh...):2.203]]
2020-02-02 14:27:11,276 |jsse-nio-8443-exec-4 |ControlServlet                |T| [[[facility::CreateShipmentNotes (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.001]]
2020-02-02 14:27:11,347 |jsse-nio-8443-exec-4 |ConfigXMLReader               |I| controller loaded: 0.001s, 0 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-02-02 14:27:11,347 |jsse-nio-8443-exec-4 |ConfigXMLReader               |I| controller loaded: 0.015s, 49 requests, 21 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-02-02 14:27:11,364 |jsse-nio-8443-exec-4 |ConfigXMLReader               |I| controller loaded: 0.001s, 4 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/webapp/WEB-INF/controller.xml
2020-02-02 14:27:11,366 |jsse-nio-8443-exec-4 |ConfigXMLReader               |I| controller loaded: 0.054s, 243 requests, 94 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/product/webapp/facility/WEB-INF/controller.xml
2020-02-02 14:27:11,366 |jsse-nio-8443-exec-4 |ConfigXMLReader               |I| controller loaded: 0.073s, 6 requests, 7 views in file:/C:/projectsASF/Git/ofbiz-framework/plugins/birt/webapp/facility/WEB-INF/controller.xml
2020-02-02 14:27:11,372 |jsse-nio-8443-exec-4 |RequestHandler                |I| Rendering View [CreateShipmentNotes].  Hidden sessionId by default.
2020-02-02 14:27:11,373 |jsse-nio-8443-exec-4 |ServiceDispatcher             |T| Sync service [facility/getUserPreferenceGroup] finished in [1] milliseconds
2020-02-02 14:27:11,384 |jsse-nio-8443-exec-4 |ScreenFactory                 |I| Got 21 screens in 0.009s from: file:/C:/projectsASF/Git/ofbiz-framework/applications/product/widget/facility/ShipmentScreens.xml
2020-02-02 14:27:11,390 |jsse-nio-8443-exec-4 |ScreenFactory                 |I| Got 4 screens in 0.005s from: file:/C:/projectsASF/Git/ofbiz-framework/applications/product/widget/facility/CommonScreens.xml
2020-02-02 14:27:11,396 |jsse-nio-8443-exec-4 |ScreenFactory                 |I| Got 1 screens in 0.005s from: file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/widget/CommonScreens.xml
2020-02-02 14:27:11,485 |jsse-nio-8443-exec-4 |ServiceDispatcher             |T| Sync service [facility/getLastSystemInfoNote] finished in [10] milliseconds
2020-02-02 14:27:11,498 |jsse-nio-8443-exec-4 |ScreenFactory                 |I| Got 26 screens in 0.007s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/common/widget/CommonScreens.xml
2020-02-02 14:27:11,672 |jsse-nio-8443-exec-4 |ScreenFactory                 |I| Got 25 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-02-02 14:27:11,748 |jsse-nio-8443-exec-4 |ServerHitBin                  |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-02-02 14:27:11,749 |jsse-nio-8443-exec-4 |ControlServlet                |T| [[[facility::CreateShipmentNotes (Domain:https://localhost)] Request Done- total:0.473,since last([facility::Create...):0.473]]
2020-02-02 14:27:30,865 |jsse-nio-8443-exec-5 |ControlServlet                |T| [[[facility::AddShipmentNotes (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-02-02 14:27:30,930 |jsse-nio-8443-exec-5 |ConfigXMLReader               |I| controller loaded: 0.0s, 0 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-02-02 14:27:30,930 |jsse-nio-8443-exec-5 |ConfigXMLReader               |I| controller loaded: 0.014s, 49 requests, 21 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-02-02 14:27:30,945 |jsse-nio-8443-exec-5 |ConfigXMLReader               |I| controller loaded: 0.0s, 4 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/webapp/WEB-INF/controller.xml
2020-02-02 14:27:30,947 |jsse-nio-8443-exec-5 |ConfigXMLReader               |I| controller loaded: 0.047s, 243 requests, 94 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/product/webapp/facility/WEB-INF/controller.xml
2020-02-02 14:27:30,947 |jsse-nio-8443-exec-5 |ConfigXMLReader               |I| controller loaded: 0.065s, 6 requests, 7 views in file:/C:/projectsASF/Git/ofbiz-framework/plugins/birt/webapp/facility/WEB-INF/controller.xml
2020-02-02 14:27:30,998 |jsse-nio-8443-exec-5 |GroupServiceModel             |I| Running grouped service [createNote]
2020-02-02 14:27:31,056 |jsse-nio-8443-exec-5 |SequenceUtil                  |I| Got bank of sequenced IDs for [NoteData]; curSeqId=10080, maxSeqId=10090, bankSize=10
2020-02-02 14:27:31,075 |jsse-nio-8443-exec-5 |ServiceDispatcher             |T| Sync service [facility/createNote] finished in [77] milliseconds
2020-02-02 14:27:31,075 |jsse-nio-8443-exec-5 |GroupServiceModel             |I| Running grouped service [createShipmentNote]
2020-02-02 14:27:31,162 |jsse-nio-8443-exec-5 |UtilProperties                |I| ResourceBundle ServiceUiLabels (fr) created in 0.05s with 4 properties
2020-02-02 14:27:31,162 |jsse-nio-8443-exec-5 |ServiceDispatcher             |T| Sync service [facility/createShipmentNote] finished in [87] milliseconds
2020-02-02 14:27:31,162 |jsse-nio-8443-exec-5 |ServiceDispatcher             |T| Sync service [facility/createShipmentNoteData] finished in [210] milliseconds
2020-02-02 14:27:31,162 |jsse-nio-8443-exec-5 |RequestHandler                |I| Ran Event [service:#createShipmentNoteData] from [request], result is [success]
2020-02-02 14:27:31,163 |jsse-nio-8443-exec-5 |RequestHandler                |I| Sending redirect to: [https://localhost:8443/facility/control/ViewShipment?shipmentId=9996&csrfToken=JuvnTHhVaDgx].  Hidden sessionId by default.
2020-02-02 14:27:31,165 |jsse-nio-8443-exec-5 |ServerHitBin                  |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-02-02 14:27:31,166 |jsse-nio-8443-exec-5 |ControlServlet                |T| [[[facility::AddShipmentNotes (Domain:https://localhost)] Request Done- total:0.301,since last([facility::AddShi...):0.301]]
2020-02-02 14:27:31,598 |sse-nio-8443-exec-10 |ControlServlet                |T| [[[facility::ViewShipment (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-02-02 14:27:31,603 |sse-nio-8443-exec-10 |RequestHandler                |I| Rendering View [ViewShipment].  Hidden sessionId by default.
2020-02-02 14:27:31,604 |sse-nio-8443-exec-10 |ServiceDispatcher             |T| Sync service [facility/getUserPreferenceGroup] finished in [1] milliseconds
2020-02-02 14:27:31,613 |sse-nio-8443-exec-10 |ScreenFactory                 |I| Got 21 screens in 0.007s from: file:/C:/projectsASF/Git/ofbiz-framework/applications/product/widget/facility/ShipmentScreens.xml
2020-02-02 14:27:32,049 |sse-nio-8443-exec-10 |ScreenFactory                 |I| Got 4 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/applications/product/widget/facility/CommonScreens.xml
2020-02-02 14:27:32,055 |sse-nio-8443-exec-10 |ScreenFactory                 |I| Got 1 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/widget/CommonScreens.xml
2020-02-02 14:27:32,142 |sse-nio-8443-exec-10 |ServiceDispatcher             |T| Sync service [facility/getLastSystemInfoNote] finished in [15] milliseconds
2020-02-02 14:27:32,158 |sse-nio-8443-exec-10 |ScreenFactory                 |I| Got 26 screens in 0.008s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/common/widget/CommonScreens.xml
2020-02-02 14:27:32,359 |sse-nio-8443-exec-10 |ScreenFactory                 |I| Got 25 screens in 0.007s from: file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-02-02 14:27:32,507 |sse-nio-8443-exec-10 |ConfigXMLReader               |I| controller loaded: 0.003s, 379 requests, 154 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/content/webapp/content/WEB-INF/controller.xml
2020-02-02 14:27:32,511 |sse-nio-8443-exec-10 |ConfigXMLReader               |I| controller loaded: 0.067s, 378 requests, 153 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/order/webapp/ordermgr/WEB-INF/controller.xml
2020-02-02 14:27:32,565 |sse-nio-8443-exec-10 |ConfigXMLReader               |I| controller loaded: 0.0s, 26 requests, 10 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/portal-controller.xml
2020-02-02 14:27:32,570 |sse-nio-8443-exec-10 |ConfigXMLReader               |I| controller loaded: 0.023s, 539 requests, 178 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/product/webapp/catalog/WEB-INF/controller.xml
2020-02-02 14:27:32,608 |sse-nio-8443-exec-10 |ServerHitBin                  |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-02-02 14:27:32,609 |sse-nio-8443-exec-10 |ControlServlet                |T| [[[facility::ViewShipment (Domain:https://localhost)] Request Done- total:1.011,since last([facility::ViewSh...):1.011]]
2020-02-02 14:28:13,555 |jsse-nio-8443-exec-1 |ControlServlet                |T| [[[facility::CreateShipmentNotes (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-02-02 14:28:13,624 |jsse-nio-8443-exec-1 |ConfigXMLReader               |I| controller loaded: 0.0s, 0 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-02-02 14:28:13,624 |jsse-nio-8443-exec-1 |ConfigXMLReader               |I| controller loaded: 0.015s, 49 requests, 21 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-02-02 14:28:13,640 |jsse-nio-8443-exec-1 |ConfigXMLReader               |I| controller loaded: 0.0s, 4 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/webapp/WEB-INF/controller.xml
2020-02-02 14:28:13,642 |jsse-nio-8443-exec-1 |ConfigXMLReader               |I| controller loaded: 0.05s, 243 requests, 94 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/product/webapp/facility/WEB-INF/controller.xml
2020-02-02 14:28:13,642 |jsse-nio-8443-exec-1 |ConfigXMLReader               |I| controller loaded: 0.068s, 6 requests, 7 views in file:/C:/projectsASF/Git/ofbiz-framework/plugins/birt/webapp/facility/WEB-INF/controller.xml
2020-02-02 14:28:13,646 |jsse-nio-8443-exec-1 |RequestHandler                |I| Rendering View [CreateShipmentNotes].  Hidden sessionId by default.
2020-02-02 14:28:13,647 |jsse-nio-8443-exec-1 |ServiceDispatcher             |T| Sync service [facility/getUserPreferenceGroup] finished in [1] milliseconds
2020-02-02 14:28:13,656 |jsse-nio-8443-exec-1 |ScreenFactory                 |I| Got 21 screens in 0.007s from: file:/C:/projectsASF/Git/ofbiz-framework/applications/product/widget/facility/ShipmentScreens.xml
2020-02-02 14:28:13,663 |jsse-nio-8443-exec-1 |ScreenFactory                 |I| Got 4 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/applications/product/widget/facility/CommonScreens.xml
2020-02-02 14:28:13,669 |jsse-nio-8443-exec-1 |ScreenFactory                 |I| Got 1 screens in 0.005s from: file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/widget/CommonScreens.xml
2020-02-02 14:28:13,739 |jsse-nio-8443-exec-1 |ServiceDispatcher             |T| Sync service [facility/getLastSystemInfoNote] finished in [10] milliseconds
2020-02-02 14:28:13,748 |jsse-nio-8443-exec-1 |ScreenFactory                 |I| Got 26 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/common/widget/CommonScreens.xml
2020-02-02 14:28:13,925 |jsse-nio-8443-exec-1 |ScreenFactory                 |I| Got 25 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-02-02 14:28:14,005 |jsse-nio-8443-exec-1 |ServerHitBin                  |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-02-02 14:28:14,006 |jsse-nio-8443-exec-1 |ControlServlet                |T| [[[facility::CreateShipmentNotes (Domain:https://localhost)] Request Done- total:0.451,since last([facility::Create...):0.451]]
2020-02-02 14:28:43,077 |jsse-nio-8443-exec-2 |ControlServlet                |T| [[[facility::ViewShipment (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-02-02 14:28:43,147 |jsse-nio-8443-exec-2 |ConfigXMLReader               |I| controller loaded: 0.0s, 0 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-02-02 14:28:43,148 |jsse-nio-8443-exec-2 |ConfigXMLReader               |I| controller loaded: 0.018s, 49 requests, 21 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-02-02 14:28:43,168 |jsse-nio-8443-exec-2 |ConfigXMLReader               |I| controller loaded: 0.0s, 4 requests, 0 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/webapp/WEB-INF/controller.xml
2020-02-02 14:28:43,171 |jsse-nio-8443-exec-2 |ConfigXMLReader               |I| controller loaded: 0.059s, 243 requests, 94 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/product/webapp/facility/WEB-INF/controller.xml
2020-02-02 14:28:43,171 |jsse-nio-8443-exec-2 |ConfigXMLReader               |I| controller loaded: 0.078s, 6 requests, 7 views in file:/C:/projectsASF/Git/ofbiz-framework/plugins/birt/webapp/facility/WEB-INF/controller.xml
2020-02-02 14:28:43,176 |jsse-nio-8443-exec-2 |RequestHandler                |I| Rendering View [ViewShipment].  Hidden sessionId by default.
2020-02-02 14:28:43,177 |jsse-nio-8443-exec-2 |ServiceDispatcher             |T| Sync service [facility/getUserPreferenceGroup] finished in [1] milliseconds
2020-02-02 14:28:43,238 |jsse-nio-8443-exec-2 |ScreenFactory                 |I| Got 21 screens in 0.009s from: file:/C:/projectsASF/Git/ofbiz-framework/applications/product/widget/facility/ShipmentScreens.xml
2020-02-02 14:28:43,725 |jsse-nio-8443-exec-2 |ScreenFactory                 |I| Got 4 screens in 0.005s from: file:/C:/projectsASF/Git/ofbiz-framework/applications/product/widget/facility/CommonScreens.xml
2020-02-02 14:28:43,731 |jsse-nio-8443-exec-2 |ScreenFactory                 |I| Got 1 screens in 0.005s from: file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/widget/CommonScreens.xml
2020-02-02 14:28:43,805 |jsse-nio-8443-exec-2 |ServiceDispatcher             |T| Sync service [facility/getLastSystemInfoNote] finished in [9] milliseconds
2020-02-02 14:28:43,815 |jsse-nio-8443-exec-2 |ScreenFactory                 |I| Got 26 screens in 0.006s from: file:/C:/projectsASF/Git/ofbiz-framework/framework/common/widget/CommonScreens.xml
2020-02-02 14:28:44,042 |jsse-nio-8443-exec-2 |ScreenFactory                 |I| Got 25 screens in 0.007s from: file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-02-02 14:28:44,148 |jsse-nio-8443-exec-2 |ConfigXMLReader               |I| controller loaded: 0.004s, 379 requests, 154 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/content/webapp/content/WEB-INF/controller.xml
2020-02-02 14:28:44,152 |jsse-nio-8443-exec-2 |ConfigXMLReader               |I| controller loaded: 0.025s, 378 requests, 153 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/order/webapp/ordermgr/WEB-INF/controller.xml
2020-02-02 14:28:44,207 |jsse-nio-8443-exec-2 |ConfigXMLReader               |I| controller loaded: 0.0s, 26 requests, 10 views in file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/portal-controller.xml
2020-02-02 14:28:44,212 |jsse-nio-8443-exec-2 |ConfigXMLReader               |I| controller loaded: 0.024s, 539 requests, 178 views in file:/C:/projectsASF/Git/ofbiz-framework/applications/product/webapp/catalog/WEB-INF/controller.xml
2020-02-02 14:28:44,255 |jsse-nio-8443-exec-2 |ServerHitBin                  |I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-02-02 14:28:44,256 |jsse-nio-8443-exec-2 |ControlServlet                |T| [[[facility::ViewShipment (Domain:https://localhost)] Request Done- total:1.179,since last([facility::ViewSh...):1.179]]
{noformat}

But I see no notes at the bottom of shipment. Nor can I update or delete this note. I used shipmentId=9996 of Demo1002 order.
Could I miss something?

> Add shipment notes
> ------------------
>
>                 Key: OFBIZ-11236
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11236
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Gaudin Pierre
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-11236_shipmentNotesV3.patch
>
>
> Hello,
> For many entities there are associated notes. However, there are no notes associated with shipments.
> The purpose of this patch is therefore to add notes to the shipments.
> A new tab called "note" appears when displaying a shipment. From this tab it is possible to add a note. From the shipment overview a section displays the notes associated with the shipment.
> For this new feature a "ShipmentNote" entity has been added. In the same way, all the services allowing the management of notes have been associated.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)