[
https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034438#comment-17034438 ]
Pierre Smits commented on OFBIZ-11236:
--------------------------------------
Pierre,
I totally have no issues with you doing your thing the way you want to do it.
But consider this: Devanshu asked you to consider the delete function for this and you did a new contribution, and then Jacques brought up the other delete and update issue requiring more time to get this ticket closed. Both valid things to consider at another time. But before long another 'what about'-thing will be brought forward. And on and on.... And then this relatively small, but good, contribution will balloon into something even more time consuming. We should avoid that.
As Jacques has told me a few times in the past 12 years (and I am paraphrasing here): something done in less than 10 mins should be good enough for the next step.
We don't need to get perfect be the enemy of good enough.
Best regards,
Pierre
> Add shipment notes
> ------------------
>
> Key: OFBIZ-11236
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11236> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Affects Versions: Trunk
> Reporter: Gaudin Pierre
> Priority: Minor
> Labels: shipment
> Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot 2020-02-11 at 08.53.37.png
>
>
> Hello,
> For many entities there are associated notes. However, there are no notes associated with shipments.
> The purpose of this patch is therefore to add notes to the shipments.
> A new tab called "note" appears when displaying a shipment. From this tab it is possible to add a note. From the shipment overview a section displays the notes associated with the shipment.
> For this new feature a "ShipmentNote" entity has been added. In the same way, all the services allowing the management of notes have been associated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
