[
https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183889#comment-17183889 ]
Jacques Le Roux commented on OFBIZ-11251:
-----------------------------------------
As commented at
https://s.apache.org/dvgcm in OFBIZ-11304, nothing should be needed in plugins. It's checked while checking the trunk in Buildbot. I also have have plugins embedded as a clone into framework locally. So it's part of the checkstyle when pushing framework. I suggest that all committers do the same...
> Use ‘checkstyle’ linting tool
> -----------------------------
>
> Key: OFBIZ-11251
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11251> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Aditya Sharma
> Priority: Minor
> Fix For: 18.12.01, Upcoming Branch
>
> Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch
>
>
> Linting [1] is a software engineering practice which make the code
> more readable and maintainable by improving its consistency and
> avoiding potential programming mistakes.
> Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which
> provides such facility. The lint actions are triggered when running
> ‘gradle check’.
> There are a lot reported errors that will need to be fixed
> incrementally in the future. We ensure that new errors will not be
> introduced by defining a global threshold of “allowed” errors
> corresponding to the sum of errors currently found in the framework
> and in the official plugins.
> [1]
https://en.wikipedia.org/wiki/Lint_(software)
> [2]
https://checkstyle.org/> [3]
https://docs.gradle.org/current/userguide/checkstyle_plugin.html--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
