[jira] [Commented] (OFBIZ-11296) Use 'depends-on' everywhere

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039011#comment-17039011 ]

Pierre Smits commented on OFBIZ-11296:
--------------------------------------

Some pre-Merge test rest results:
{code:java}
+1 overall


 ____                              _ 
/ ___| _   _  ___ ___ ___  ___ ___| |
\___ \| | | |/ __/ __/ _ \/ __/ __| |
 ___) | |_| | (_| (_|  __/\__ \__ \_|
|____/ \__,_|\___\___\___||___/___(_)
                                     




| Vote |      Subsystem |  Runtime   | Comment
============================================================================
|   0  |        reexec  |   0m 51s   | Docker mode activated. 
+---------------------------------------------------------------------------
|      |                |            | Prechecks 
+---------------------------------------------------------------------------
|  +1  |       dupname  |   0m  0s   | No case conflicting files found. 
|  +1  |       @author  |   0m  0s   | The patch does not contain any @author 
|      |                |            | tags.
|  -0  |    test4tests  |   0m  0s   | The patch doesn't appear to include any 
|      |                |            | new or modified tests. Please justify why
|      |                |            | no new tests are needed for this patch.
|      |                |            | Also please list what manual steps were
|      |                |            | performed to verify this patch.
+---------------------------------------------------------------------------
|      |                |            | trunk Compile Tests 
+---------------------------------------------------------------------------
|  +1  |       compile  |  27m 20s   | trunk passed 
|  +1  |    checkstyle  |  16m 12s   | trunk passed 
|  +1  |       javadoc  |   4m 49s   | trunk passed 
+---------------------------------------------------------------------------
|      |                |            | Patch Compile Tests 
+---------------------------------------------------------------------------
|  +1  |       compile  |   8m  0s   | the patch passed 
|  +1  |         javac  |   8m  0s   | the patch passed 
|  +1  |    checkstyle  |  15m 13s   | the patch passed 
|  +1  |    whitespace  |   0m  0s   | The patch has no whitespace issues. 
|  +1  |       javadoc  |   4m 23s   | the patch passed 
+---------------------------------------------------------------------------
|      |                |            | Other Tests 
+---------------------------------------------------------------------------
|   0  |    asflicense  |   0m 57s   | ASF License check generated no output? 
|      |                |  92m 31s   | 

{code}

> Use 'depends-on' everywhere
> ---------------------------
>
>                 Key: OFBIZ-11296
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11296
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-11296_0001-Improved-Use-depends-on-attribute-instead-of-compone.patch, OFBIZ-11296_ignore-depends-on-when-a-component-load.xml-is-prese.patch
>
>
> We currently have two ways to define component loading order. Either
> by using ‘depends-on’ attribute in “component-config.xml” or by adding
> a “component-load.xml” file at the root of a component directory.
> “depends-on” is more flexible because it handles partial ordering when
> “component-load.xml” defines a total order which is not necessarily
> meaningful, so it is better to rely only “depends-on”.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)