[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129229#comment-17129229 ]

Jacques Le Roux commented on OFBIZ-11304:
-----------------------------------------

Hi Aditya,

I'm facing a weird issue that seems related to the work here but I can't understand why. Yesterday I tried but uninstalled/reverted the work here. Today I committed https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ed6a6fe. I wanted to backport it and after cherry picking tried to commit. I got this


{noformat}
$ git status
On branch release18.12
Your branch is up to date with 'origin/release18.12'.

You are currently cherry-picking commit ed6a6fe3d3.
  (all conflicts fixed: run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
        modified:   .gitignore

Jacques@LDLC MINGW64 /c/projectsASF/Git/ofbiz-framework (release18.12|CHERRY-PICKING)
$ git cherry-pick --continue

FAILURE: Build failed with an exception.

* What went wrong:
Task 'checkstyleMain' not found in root project 'ofbiz'.

* Try:
Run gradlew tasks to get a list of available tasks. Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 0s
{noformat}

And I can't commit. I don't understand why when committing Git refers to 'checkstyleMain'. Any ideas?

> Install a Checkstyle pre-push (on every committer machine?)
> -----------------------------------------------------------
>
>                 Key: OFBIZ-11304
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11304
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the check gradle task. It's "hard" to exactly know from where lint errors  come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when a lint error is present in the commit.
> Every committer would have it installed locally and the problem would be gone with some committers good will. I started a discussion about it at https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3

--
This message was sent by Atlassian Jira
(v8.3.4#803005)