[
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129244#comment-17129244 ]
Jacques Le Roux commented on OFBIZ-11304:
-----------------------------------------
OK got it. Once tried, a .git/hooks directory is created and it's not specific to trunk (can't be committed). Removing it by hand made the trick but it seems "git commit with --no-verify" will be helpful in the future, not sure how Git UI clients like ToirtoiseGit can handle that though...
There is maybe someting to worry about though, see the bottom of
https://stackoverflow.com/questions/39963695/how-to-remove-git-hooks:bq. --no-verify is only partially helpful. If you want to do git checkout or wanna do git rebase -i, and those commits won't be allowed, there's nothing you can do. – Danon Jan 30 '19 at 12:3
> Install a Checkstyle pre-push (on every committer machine?)
> -----------------------------------------------------------
>
> Key: OFBIZ-11304
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11304> Project: OFBiz
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the check gradle task. It's "hard" to exactly know from where lint errors come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like
https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when a lint error is present in the commit.
> Every committer would have it installed locally and the problem would be gone with some committers good will. I started a discussion about it at
https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same proposition years ago:
https://markmail.org/message/gkgmko4axj3vtnv3--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
