[
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134673#comment-17134673 ]
Jacques Le Roux commented on OFBIZ-11304:
-----------------------------------------
Hi Aditya,
I have pushed a pre-push hook rather than a pre-commit hook. I think it makes sense. I noticed that this does not clear the existing pre-commit hook in .git\hooks. You have to clear it by hand.
If instead of no-verify there was verify commit option we could have used it locally for people who want to check before pushing but tend to forget the check task.
But anyway I believe we should rather use a webhook as proposed by Infra. This for at least 3 reasons:
# Handles PRs and not only local commits
# Minimise the CPU usage locally
# Simplify usage for custom projects
There were not much exchanges about the feature in the dev ML. I'll though let people know about this decision and wait possible feebacks before commenting out the feature and let people know it exists in documentation and ask Infra to create a webhook.
> Install a Checkstyle pre-push (on every committer machine?)
> -----------------------------------------------------------
>
> Key: OFBIZ-11304
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11304> Project: OFBiz
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the check gradle task. It's "hard" to exactly know from where lint errors come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like
https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when a lint error is present in the commit.
> Every committer would have it installed locally and the problem would be gone with some committers good will. I started a discussion about it at
https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same proposition years ago:
https://markmail.org/message/gkgmko4axj3vtnv3--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
