[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138695#comment-17138695 ]

Jacques Le Roux commented on OFBIZ-11304:
-----------------------------------------

OK this works, see " Build with Gradle" step at https://github.com/apache/ofbiz-framework/runs/781401208?check_suite_focus=true

but I have still to see how to prevent a PR merge in case of failure because https://stackoverflow.com/questions/57741805/how-can-i-reject-push-from-repository-members-using-github-actions confirms what Daniel said.

I found https://help.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests and https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. But none of us are GH ASF repos admins so I'll have to ask Infra again and I fear the https://developer.github.com/v3/guides/building-a-ci-server/ aspect will not be easily accepted by them, let's see...

Maybe we can create our own CI server and use BuildBot has our status server. But how to relate the failure of the checkstyle step there to GH status is still to investigate...

Begin to be a lot for rejecting check style failures on PR merge,  I better understand Infra reaction now ;)

> Install a Checkstyle pre-push (on every committer machine?)
> -----------------------------------------------------------
>
>                 Key: OFBIZ-11304
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11304
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the check gradle task. It's "hard" to exactly know from where lint errors  come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when a lint error is present in the commit.
> Every committer would have it installed locally and the problem would be gone with some committers good will. I started a discussion about it at https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3

--
This message was sent by Atlassian Jira
(v8.3.4#803005)