[
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162800#comment-17162800 ]
ASF subversion and git services commented on OFBIZ-11304:
---------------------------------------------------------
Commit bf0c628dfb8a9bcc11e0450117f984dac8727098 in ofbiz-framework's branch refs/heads/release17.12 from Aditya Sharma
[
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bf0c628 ]
Fixed: pre push failures due to absence of checkstyle plugin (OFBIZ-11304)
We have added a Gradle plugin com.github.jakemarsden.git-hooks which install pre push hook on developer machine, but due to limitations of checkstyle plugin with the Gradle version of release 17.12 these changes cannot be backported. Once the hook is installed it is difficult to remove the hook when branch changes. With the absence of checkstyle plugin, the hook fails when pushing code. To avoid such failures added a dummy task with the same name.
> Install a Checkstyle pre-push (on every committer machine?)
> -----------------------------------------------------------
>
> Key: OFBIZ-11304
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11304> Project: OFBiz
> Issue Type: Sub-task
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: Aditya Sharma
> Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the check gradle task. It's "hard" to exactly know from where lint errors come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like
https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when a lint error is present in the commit.
> Every committer would have it installed locally and the problem would be gone with some committers good will. I started a discussion about it at
https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same proposition years ago:
https://markmail.org/message/gkgmko4axj3vtnv3--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
