[jira] [Commented] (OFBIZ-11306) POC for CSRF Token

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045625#comment-17045625 ]

Jacques Le Roux commented on OFBIZ-11306:
-----------------------------------------

Hi James,

Despite having this local Git config:

{noformat}
[remote "origin"]
        url = https://gitbox.apache.org/repos/asf/ofbiz-framework.git
    fetch = +refs/pull/*/merge:refs/remotes/origin/pr/*
        fetch = +refs/heads/*:refs/remotes/origin/*
        puttykeyfile = C:\\[hidden email]
[remote "OFBiz"]
        url = https://github.com/apache/ofbiz-framework.git
        fetch = +refs/pull/*/merge:refs/remotes/OFBiz/pr/*
        fetch = +refs/heads/*:refs/remotes/OFBiz/*
{noformat}

and pushing to "OFBiz" remote, my local branch finally ended at
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=shortlog;h=refs/heads/POC-for-CSRF-Token-OFBIZ-11306 instead of a branch of https://github.com/JacquesLeRoux/ofbiz-framework to where I expect to push the new local branch.

I don't think it's a big deal for 2 reasons:
* we are near an end and mostly need reviews and tests from others now
* we are both committers

So we can not only both work from this feature branch but also others can.

> POC for CSRF Token
> ------------------
>
>                 Key: OFBIZ-11306
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11306
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>    Affects Versions: Upcoming Branch
>            Reporter: James Yong
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: CSRF
>             Fix For: Upcoming Branch
>
>         Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch, OFBIZ-11306-alternative merged with James's.patch, OFBIZ-11306-alternative merged with James's.patch, OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, OFBIZ-11306-v2.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, partyTokenMap.webtools.txt
>
>
> CRSF tokens are generated using SecureRandom class (maybe later a JWT with a "time out").
> They are stored in the user sessions (for AJAX calls and unauthenticated HTTP calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during POST request.
> # In *controllers* a new csrf-token attribute is added to the security tag to exempt or force CSRF token check.
> # In *Widget Forms* a hidden token field is auto-generated.
> # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the change. Using <@ofbizUrl> macro to generate the CSRF token means there is no need to manually add the CSRF token field to each form in the ftl files. It will save time for users doing custom implementation and maintenance.  While there is CSRF token in the form URL, the token is invalidated during form submission. So it's uniqueand harmless even though the CSRF token of the form submission is shown in the browser address bar.
> # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added through OfbizUtil.js (itself called at start in decorators and such)
> # The html metadata is storing the csrf token used by JQuery AJAX. This token will not change to another value after it is consumed
> # Csrf tokens for the user are removed from the UtilCache when the user logs out or session invalidated.
> The general rule are as follows:
> * RequestMap configured with 'get' method will be exempted from CSRF token check.
> * RequestMap configured with 'post' or 'all' method will be subjected to CSRF token check. (Note there are discussions that RequestMap with ‘all’ method should also not be subjected to CSRF token check. This will be done after ensuring a separate uri is used when posting changes.)
> * "main" request URIs are exempted from CSRF token check.
> * Setting csrf-token to false or true on the Request Map will override the general rules above.
> To Discuss:
> * Invalidate authenticated user session when CSRF token check fails.
> * Configure the general rules in a Service method (which will be run inside the constructor of RequestMap class) when determining the final securityCsrfToken value.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)