[
https://issues.apache.org/jira/browse/OFBIZ-11314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006881#comment-17006881 ]
Mathieu Lirzin commented on OFBIZ-11314:
----------------------------------------
I will commit [^0001-Improved-Rewrite-Digraph.patch] and [^0002-Improved-Detect-inclusion-cycles-in-controller-confi.patch] in 3 days if nobody objects.
Those patches are meant to be applied in order and must be applied using {{git am XXX.patch}}.
> Avoid stack overflow in the presence of cycles in controller inclusion
> ----------------------------------------------------------------------
>
> Key: OFBIZ-11314
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11314> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Mathieu Lirzin
> Priority: Minor
> Attachments: 0001-Improved-Rewrite-Digraph.patch, 0002-Improved-Detect-inclusion-cycles-in-controller-confi.patch
>
>
> The inclusion of controller configuration files can lead to inclusion cycles which are not safely handled, because they can lead to infinite recursion that end up in stack overflow exception.
> A very basic form of cycle is controllers A and B which includes each other.
> I would be better to checket the inclusion cycles and report an appropriate error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
