[jira] [Commented] (OFBIZ-11316) Bug when order contains adjustments with NULL amount

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012752#comment-17012752 ]

Jacques Le Roux commented on OFBIZ-11316:
-----------------------------------------

Hi Amine,

Which version are you using? Could you provide a patch against trunk?

> Bug when order contains adjustments with NULL amount
> ----------------------------------------------------
>
>                 Key: OFBIZ-11316
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11316
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Amine Azzi
>            Assignee: Jacques Le Roux
>            Priority: Major
>
> On org/apache/ofbiz/accounting/invoice/InvoiceServices.java:561.
> The condition evaluation gives an error when the adjustment has a null amount even when isTaxIncludedInPrice is FALSE.
>  
> The condition should be re-written to
>  
> if (isTaxIncludedInPrice && (adj.getBigDecimal("amount").signum() == 0))

--
This message was sent by Atlassian Jira
(v8.3.4#803005)