[
https://issues.apache.org/jira/browse/OFBIZ-11335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040983#comment-17040983 ]
ASF subversion and git services commented on OFBIZ-11335:
---------------------------------------------------------
Commit d8641bce8c1d33703b85ca7366915e4ae0033fe2 in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin
[
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d8641bc ]
Fixed: Correct FoFormMacro to support form list with non separate fields
(OFBIZ-11335)
Related to issue OFBIZ-11335 when a form list haven't the attribute separate-column to true,
the screen engine failed to rendering it through screen-fop due to a block present on table-row without table-cell.
We have in log some line like :
ScreenFopViewHandler |E| Unable to transform FO file: org.apache.fop.apps.FOPException: javax.xml.transform.TransformerException: org.apache.fop.fo.ValidationException: null:150:2: "fo:block" is not a valid child of "fo:table-row"!
Simple fix is to open and close a table-cell when renderFormatHeaderRowFormCell[Open/Close] and renderFormatItemRowFormCell[Open/Close] are called.
> Add CommonForms as template pattern configured by theme
> -------------------------------------------------------
>
> Key: OFBIZ-11335
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11335> Project: OFBiz
> Issue Type: New Feature
> Components: framework, themes
> Affects Versions: Trunk
> Reporter: Nicolas Malin
> Assignee: Nicolas Malin
> Priority: Major
> Attachments: OFBIZ-11335.patch
>
>
> Currently on OFBiz we implemented a process to define some different screen and menu that can be implemented by the theming
> But for the form we have nothing. All style are hard coded on each
> {code:java}
> <grid name="ListEntities" ...
> odd-row-style="alternate-row" default-table-style="basic-table hover-bar">{code}
>
> I propose to extend the theming implementation principle to forms element.
> To start low, I define seven form tempates :
> * grid CommonSimpleGrid
> * grid CommonBasicGrid
> * form CommonSimpleList
> * form CommonBasicList
> * form CommonInLineEditList
> * form CommonSimpleSingle
> * form CommonBasicSingle
>
> We can use its like :
> {code:java}
> <form name="LayoutDemoList" extends="CommonBasicList" extends-resource="component://common/widget/CommonForms.xml"{code}
> The main difficulty raise to this task was propage the visualTheme during the ModelForm intanciation, because we need to load wiget style (and some other information wanted on the template) on model load in memory.
> With the linked patch I improved form present on screen
> [
https://localhost:8443/webtools/control/WebtoolsLayoutDemo]
>
> Finally with this we can extend style form (pagination, header, line and so on ...) direclty by your theme without change the framework
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
