[
https://issues.apache.org/jira/browse/OFBIZ-11344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105145#comment-17105145 ]
Pierre Smits commented on OFBIZ-11344:
--------------------------------------
Ahh thanks.
I don't worry about that.
The questions to ask ourselves are:
* Is the PR good enough?
I would say it is, as it addresses the original intent of the contributors as highlighted in the title of each ticket and described in the subjects. It seems the PR passes the review muster of those having done that and didn't bring forward any issues.
* Does the PR do right with respect to attributions?
Yes it does, as authors (committers) are referenced.
The contributions regarding the 3 tickets don't bite each other? No, they don't. But yes, keeping them separate would have been better. That is a lesson learned.
Now, the risk of any of the commits leading to merge conflict is non-existent at the moment. So, any contributor can take the PR forward. Whether that be checking it out and enhance it with he/she deems necessary (regarding the 3 tickets), or just merge it (those who can) as is and leave the suggestions/questions to be handled in new tickets.
Both will work for me.
> Move Shipment menus and menu-items from ftl to xml
> ---------------------------------------------------
>
> Key: OFBIZ-11344
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11344> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Assignee: Pierre Smits
> Priority: Major
>
> Currently shipment related menu and/or menu-items are coded in a Freemarker template file. While this is acceptable in exceptional cases, the convention is to have menus and their items in an appropriate xml file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
