[
https://issues.apache.org/jira/browse/OFBIZ-11344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105258#comment-17105258 ]
Michael Brohl commented on OFBIZ-11344:
---------------------------------------
This should be handled in a different PR than the linked one because the PR includes other changes and new features.
The PR also includes one commit with references to 3 Jiras. These should be separated also. Having them alltogether makes review and possible reverts more complex and prevents simple changes to get committed because of other changes/new features coming with them.
> Move Shipment menus and menu-items from ftl to xml
> ---------------------------------------------------
>
> Key: OFBIZ-11344
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11344> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Assignee: Pierre Smits
> Priority: Major
>
> Currently shipment related menu and/or menu-items are coded in a Freemarker template file. While this is acceptable in exceptional cases, the convention is to have menus and their items in an appropriate xml file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
