[
https://issues.apache.org/jira/browse/OFBIZ-11344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105274#comment-17105274 ]
Jacques Le Roux commented on OFBIZ-11344:
-----------------------------------------
I agree with Michael,
Notably, we should always keep in mind the "revert effect". Even if you can partially revers a commit (by files) it's always a pain (lesson already learned several times...). I'd not commit a PR with a such "danger", not speaking about the other aspects well explained by Michael.
> Move Shipment menus and menu-items from ftl to xml
> ---------------------------------------------------
>
> Key: OFBIZ-11344
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11344> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Assignee: Pierre Smits
> Priority: Major
>
> Currently shipment related menu and/or menu-items are coded in a Freemarker template file. While this is acceptable in exceptional cases, the convention is to have menus and their items in an appropriate xml file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
