[jira] [Commented] (OFBIZ-11350) Checkstyle improvements

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11350) Checkstyle improvements

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282952#comment-17282952 ]

Jacques Le Roux commented on OFBIZ-11350:
-----------------------------------------

Hi Wiebke,

bq.  My idea would be either to store the type cast before in an own variable or to adapt the checkstyle rules. What are your opinions?
Is it possible to adapt the checkstyle rules at this level? I mean specifying type cast and wraping '('? Else I'd say it's better to fix them.

bq. The name of the functions are all in upper case while it should be lower case letters.
I guess it's due to being related to SQL. I have a mixed feeling on that, I'd recommend to discuss that on dev ML...



> Checkstyle improvements
> -----------------------
>
>                 Key: OFBIZ-11350
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11350
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>
> This is an umbrella task for checkstyle improvements.
> See related discussion on the dev mailinglist: https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)