[
https://issues.apache.org/jira/browse/OFBIZ-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044195#comment-17044195 ]
Pierre Smits commented on OFBIZ-11409:
--------------------------------------
HI [~jamesyong],
I haven't done a thorough analysis of MVVM and Knockout, but this ticket (and thus adopters and fellow contributors) if some documents/pages regarding both subjects would be linked.
After a cursory review of the patch, I have - for now - only one question.
In the patch you added following changes to a form in EmployeeForms.xml
{code:java}
/- <field name="firstName" required-field="true"><text/></field>
- <field name="middleName" title="${uiLabelMap.PartyMiddleInitial}"><text size="4" maxlength="4"/></field>
- <field name="lastName" required-field="true"><text/></field>
+ <field name="firstName" data-bind="textInput:firstName" required-field="true"><text/></field>
+ <field name="middleName" data-bind="textInput:middleName" title="${uiLabelMap.PartyMiddleInitial}"><text size="4" maxlength="4"/></field>
+ <field name="lastName" data-bind="textInput:lastName" required-field="true"><text/></field>
{code}
What is the impact of these changes on the user experience, when the user doesn't use a MVVM aware/enabled theme?
Given that the project not only has forms where this can be applied, but also Freemarker templates and other elements/objects that are used to render the UI, I suggest to have more applications shown (and explained) in the PoC.
Maybe you should not do this via patch files, but a feature branch in your public Github repo?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
