[jira] [Commented] (OFBIZ-11435) Remove and/or replace deprecated services

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094430#comment-17094430 ]

Suraj Khurana commented on OFBIZ-11435:
---------------------------------------

Hello Pierre,

These are deprecated since Release 18.12, I think we need to wait till we are officially on 18.12 release.
Not sure about exact policy or SOP we are following.

Please share your thoughts on this.

Here is the PR link for reference: https://github.com/apache/ofbiz-framework/pull/40/files

> Remove and/or replace deprecated services
> -----------------------------------------
>
>                 Key: OFBIZ-11435
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11435
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Major
>              Labels: refactoring
>
> Several services call functions which have been deprecated and replaced by newer functions in old release branches, like:
> * deleteRateAmount -> expireRateAmount
> * captureBillingAccountPayment -> captureBillingAccountPayments
> * createQuoteWorkEffort -> ensureWorkEffortAndCreateQuoteWorkEffort
> * addPriceRuleToMarketingCampaign -> createMarketingCampaignPrice
> * removePriceRuleFromMarketingCampaign -> deleteMarketingCampaignPrice
> * addPromoToMarketingCampaign -> createMarketingCampaignPromo
> * removePromoFromMarketingCampaign -> deleteMarketingCampaignPromo
> These must be removed from trunk.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)