[jira] [Commented] (OFBIZ-11435) Remove and/or replace deprecated services

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103791#comment-17103791 ]

Jacques Le Roux commented on OFBIZ-11435:
-----------------------------------------

Thanks Suraj,

Here is the policy about that:
 [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-Handlingdeprecatedservices]
Not sure it's really helpful, looking at the log is easier, maybe we should simplify the policy and ask to refer to the log...

The idea is that you fill a line like
bq. <deprecated use-instead="captureBillingAccountPayments" since="Releases 17.12"/>
in the depracated service definition. So captureBillingAccountPayments indeed should be be removed

Here is what I find in the current log today:
{noformat}
the service lookupParty has been deprecated and replaced by performFindParty, since Upcoming Branch because '
the service deleteRateAmount has been deprecated and replaced by expireRateAmount, since Release 18.12
the service captureBillingAccountPayment has been deprecated and replaced by captureBillingAccountPayments, since Releases 17.12
the service addRequirementTask has been deprecated and replaced by createWorkRequirementFulfillment, since Upcoming Branch because '
the service createQuoteWorkEffort has been deprecated and replaced by ensureWorkEffortAndCreateQuoteWorkEffort, since Release 18.12 because '
the service addPriceRuleToMarketingCampaign has been deprecated and replaced by createMarketingCampaignPrice, since Release 18.12 because '
the service removePriceRuleFromMarketingCampaign has been deprecated and replaced by deleteMarketingCampaignPrice, since Release 18.12 because '
the service addPromoToMarketingCampaign has been deprecated and replaced by createMarketingCampaignPromo, since Release 18.12 because '
the service removePromoFromMarketingCampaign has been deprecated and replaced by deleteMarketingCampaignPromo, since Release 18.12 because '
the service lookupParty has been deprecated and replaced by performFindParty, since Upcoming Branch because '
the service captureBillingAccountPayment has been deprecated and replaced by captureBillingAccountPayments, since Releases 17.12
the service deleteRateAmount has been deprecated and replaced by expireRateAmount, since Release 18.12
the service createQuoteWorkEffort has been deprecated and replaced by ensureWorkEffortAndCreateQuoteWorkEffort, since Release 18.12 because '
the service addRequirementTask has been deprecated and replaced by createWorkRequirementFulfillment, since Upcoming Branch because '
the service addPriceRuleToMarketingCampaign has been deprecated and replaced by createMarketingCampaignPrice, since Release 18.12 because '
the service removePriceRuleFromMarketingCampaign has been deprecated and replaced by deleteMarketingCampaignPrice, since Release 18.12 because '
the service addPromoToMarketingCampaign has been deprecated and replaced by createMarketingCampaignPromo, since Release 18.12 because '
the service removePromoFromMarketingCampaign has been deprecated and replaced by deleteMarketingCampaignPromo, since Release 18.12 because '
{noformat}

> Remove and/or replace deprecated services
> -----------------------------------------
>
>                 Key: OFBIZ-11435
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11435
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Priority: Major
>              Labels: refactoring
>
> In the code base (in trunk) there are several services call functions which have been deprecated and replaced by newer functions, such as:
>  * deleteRateAmount -> expireRateAmount
>  * captureBillingAccountPayment -> captureBillingAccountPayments
>  * createQuoteWorkEffort -> ensureWorkEffortAndCreateQuoteWorkEffort
>  * addPriceRuleToMarketingCampaign -> createMarketingCampaignPrice
>  * removePriceRuleFromMarketingCampaign -> deleteMarketingCampaignPrice
>  * addPromoToMarketingCampaign -> createMarketingCampaignPromo
>  * removePromoFromMarketingCampaign -> deleteMarketingCampaignPromo
> These must be removed from trunk, when the time is there (to be done periodically). This is a long running ticket intended to enable committers to associate a removal to a ticket upon periodical clean-up without having to create new tickets.
> It is suggested that committer the ticket under which a the replacement is committed is referenced here as a link.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)