[jira] [Commented] (OFBIZ-11448) Potential Nullpointer in ErrorPage.ftl

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11448) Potential Nullpointer in ErrorPage.ftl

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056027#comment-17056027 ]

ASF subversion and git services commented on OFBIZ-11448:
---------------------------------------------------------

Commit d83bec22d8ed17799b6c6dad5eda24a23c8823a5 in ofbiz-framework's branch refs/heads/trunk from Dennis Balkir
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d83bec2 ]

Fixed: Potential Nullpointer in ErrorPage.ftl

(OFBIZ-11448)

Inserted nullcheck for request-attribute

> Potential Nullpointer in ErrorPage.ftl
> --------------------------------------
>
>                 Key: OFBIZ-11448
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11448
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: Trunk
>            Reporter: Dennis Balkir
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This line of code right here:
> {code:java}
> <p>${request.getAttribute("_ERROR_MESSAGE_")?replace("\n", "<br/>")}</p>
> {code}
> can produce a nullpointer error, since the attribute "_ERROR_MESSAGE_" from the request ist used by the replace method of freemarker, without nullchecking it first.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)