[jira] [Commented] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17079250#comment-17079250 ]

Pawan Verma commented on OFBIZ-11479:
-------------------------------------

Hello [~priya.sharma.9362], [~jleroux]

Thanks, for the work. Sorry I got late to review the patch. I have a small suggestion, Should we use Groovy truth instead of UtilValidate Methods? Also, added some lined space to make code more beautiful :D

I've attached a patch with this improvement. If it looks good to you guys, we can proceed with it :) 

> Convert createPayment service from mini-lang to groovy DSL
> ----------------------------------------------------------
>
>                 Key: OFBIZ-11479
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11479
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Devanshu Vyas
>            Assignee: Priya Sharma
>            Priority: Minor
>         Attachments: OFBIZ-11479.patch, OFBIZ-11479.patch
>
>
> Convert the createPayment service code from mini-lang to groovy DSL.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)