[jira] [Commented] (OFBIZ-11489) Convert cancelPaymentBatch service from mini-lang to groovy DSL

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149317#comment-17149317 ]

Jacques Le Roux commented on OFBIZ-11489:
-----------------------------------------

Hi Pawan,

As is the service does not return a result when succeeding. I wrote above
bq. Also when the service succeed you should return return success()

About
bq. We can modify the existing code to use error() instead of ServiceUtil.returnError(), WDYT?
If you mean {{return error(...)}} instead of {{ ServiceUtil.returnError(...)}} in the code of this service, yes why not. I see a lot of such in other Groovy services.

> Convert cancelPaymentBatch service from mini-lang to groovy DSL
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-11489
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11489
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Devanshu Vyas
>            Assignee: Pawan Verma
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-11489.patch, OFBIZ-11489.patch, OFBIZ-11489.patch
>
>
> Convert the cancelPaymentBatch service code from mini-lang to groovy DSL.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)