[jira] [Commented] (OFBIZ-11517) Convert testCancelFixedAssetStdCost test from XML to Groovy

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11517) Convert testCancelFixedAssetStdCost test from XML to Groovy

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093066#comment-17093066 ]

Suraj Khurana commented on OFBIZ-11517:
---------------------------------------

Thanks for the explanation.

Ahh !! I see. Sorry I mixed it with another patch.

But in that case, we should use filterByDate with queryFirst, or use same hard-coded fromDate while fetching records, instead of queryFirst.

Also during review, I feel we can replace cancelFixedAssetStdCost with entity-auto service and rename it as per other service naming patterns which expires records.

HTH.

> Convert testCancelFixedAssetStdCost test from XML to Groovy
> -----------------------------------------------------------
>
>                 Key: OFBIZ-11517
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11517
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Rohit Hukkeri
>            Assignee: Rohit Hukkeri
>            Priority: Minor
>         Attachments: OFBIZ-11517.patch
>
>
> Convert testCancelFixedAssetStdCost test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)