[jira] [Commented] (OFBIZ-11618) Use userLogin available in context instead of fetching from DB in Groovy test cases

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094650#comment-17094650 ]

Jacques Le Roux commented on OFBIZ-11618:
-----------------------------------------

Hi Pawan,

Integration tests pass, it's OK with me, just 2 small points:
 # I think services_view.xml should not be part of this patch
 # and you should remove {{GenericValue userLogin = getUserLogin('flexadmin')}} from testCreateWorkEffortAndQuoteWorkEffort, default "system" should be OK

> Use userLogin available in context instead of fetching from DB in Groovy test cases
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-11618
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11618
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Pawan Verma
>            Assignee: Pawan Verma
>            Priority: Minor
>         Attachments: OFBIZ-11618.patch
>
>
> Use userLogin available in context instead of fetching from DB in Groovy test cases. I have found 30+ entries that can be replaced.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)