[jira] [Commented] (OFBIZ-11634) Deprecate unused duplicate service with different name

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11634) Deprecate unused duplicate service with different name

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097826#comment-17097826 ]

Suraj Khurana commented on OFBIZ-11634:
---------------------------------------

Thanks Jacques,

Actually there is lot of discrepancy in this service.

Service name is : addRequirementTask
Method called is : addTaskToRequirement
Actually what it is doing : createWorkRequirementFulfillment

+1 for removing it, initial thought was same, but then it reminds me that we have started marking services deprecated instead of deleting them.

*Note*: There is a test case service also in place which is of no use.

> Deprecate unused duplicate service with different name
> ------------------------------------------------------
>
>                 Key: OFBIZ-11634
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11634
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Minor
>
> Deprecate service addTaskToRequirement which simply creates WorkRequirementFulfillment record and there is already an entity-auto service (createWorkRequirementFulfillment) available to do the job.
> This service addTaskToRequirement is also not used anywhere in the code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)