[jira] [Commented] (OFBIZ-11684) Form to add an employee position doesn't function properly when invoked from Humanres tree

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309966#comment-17309966 ]

Aditya Sharma commented on OFBIZ-11684:
---------------------------------------

Hi [~jleroux] , all,

The issue doesn't exist on trunk due to work by James where we moved the logic to load datejs library in specific macros when needed
https://github.com/apache/ofbiz-framework/commit/bc5b0d595cab9103e9ec0c03234cec81c80f47c3

In releases 18.12 and 17.12, we include them through GlobalAction decorator. The issue with the current approach is the current page and the EditEmplPosition page both have GlobalActions decorator all the js files in GlobalActions are loaded twice. Either we should Ajaxify a section of the page or we should navigate the user to the EditEmplPosition page.

Here is my solution:
[https://github.com/apache/ofbiz-framework/pull/289/files]

Replaced logic to Ajaxify the response from EditEmplPosition with navigating the user to EditEmplPosition page.
When we are getting the entire page and updating it into the DOM, it would be better if we navigate the user to the page.

Other than that, I noticed that all the labels are not internationalized and there is an error for Add Internal Organisation on console:
{code:java}
jquery-3.5.1.min.js:2 Uncaught Error: cannot call methods on dialog prior to initialization; attempted to call method 'open'
 at Function.error (jquery-3.5.1.min.js:2)
 at HTMLDivElement.<anonymous> (jquery-ui-1.12.1.min.js:6)
 at Function.each (jquery-3.5.1.min.js:2)
 at s.fn.init.each (jquery-3.5.1.min.js:2)
 at s.fn.init.t.fn.<computed> [as dialog] (jquery-ui-1.12.1.min.js:6)
 at <anonymous>:2:18
 at b (jquery-3.5.1.min.js:2)
 at Pe (jquery-3.5.1.min.js:2)
 at s.fn.init.append (jquery-3.5.1.min.js:2)
 at s.fn.init.<anonymous> (jquery-3.5.1.min.js:2){code}

> Form to add an employee position doesn't function properly when invoked from Humanres tree
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-11684
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11684
>             Project: OFBiz
>          Issue Type: Bug
>          Components: humanres
>    Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, 17.12.03, Trunk, 17.12.04
>            Reporter: Pierre Smits
>            Assignee: Jacques Le Roux
>            Priority: Major
>              Labels: usability
>
> Selecting Add Employee Position or Add Person from the context menu opens the corresponding edit forms with calendar lookup fields.
> The calendar form does no open when the lookup icon is clicked.
> Expected calendar to open on click.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)