[
https://issues.apache.org/jira/browse/OFBIZ-11723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126494#comment-17126494 ]
ASF subversion and git services commented on OFBIZ-11723:
---------------------------------------------------------
Commit 73b15e98677567787e983db5d76df0f296070a44 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana
[
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=73b15e9 ]
Improved: Enforce noninstantiability to FinAccountHelper Class. (#171)
(OFBIZ-11723)
Made class as final, added private constructor, also made data members as private, defined getter methods and changed related occurrences.
> Enforce noninstantiability to FinAccountHelper Class
> ----------------------------------------------------
>
> Key: OFBIZ-11723
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11723> Project: OFBiz
> Issue Type: Sub-task
> Components: order
> Affects Versions: Trunk
> Reporter: Suraj Khurana
> Assignee: Suraj Khurana
> Priority: Major
>
> - Make FinAccountHelper class as final.
> - Add a private constructor.
> - Make the following public static variable as private.
> {code:java}
> public static final String MODULE = FinAccountHelper.class.getName();
> public static final int decimals = UtilNumber.getBigDecimalScale("finaccount.decimals");
> public static final RoundingMode rounding = UtilNumber.getRoundingMode("finaccount.rounding");
> public static final BigDecimal ZERO = BigDecimal.ZERO.setScale(decimals, rounding);
> public static final String giftCertFinAccountTypeId = "GIFTCERT_ACCOUNT";
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
