[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116661#comment-17116661 ]

Pierre Smits commented on OFBIZ-11743:
--------------------------------------

Hi [~uHeidfeld],

I made the 'Affected Version(s) field a bit more specific. Unfortunately, 17.12.01 couldn't be selected, due to guidelines/policies. See [1] and [2]

IMO, release 18.12 shouldn't be selected either, as it has no releases. It should, however, be used in the 'Fix version(s) if and when back ported.

[1] https://cwiki.apache.org/confluence/display/OFBIZ/Guidelines+For+Using+JIRA
[2] https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities

> Multiple menu item link parameters get lost if link type is layered-modal
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-11743
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11743
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/widget
>    Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>            Reporter: Ulrich Heidfeld
>            Assignee: Ulrich Heidfeld
>            Priority: Minor
>              Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline JS-Code get created with defined action-String. This String is used to set following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded like
> {code:java}
> // .../control/uri?param1=1&param2=2
> {code}
>  
> My solution for this problem was to extend MacroMenuRenderer#renderLink by replacing 
> {code:java}
> &{code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between menus link tags, will be ignored, if link type is 'layered-modal'. So, within action-String, we have to submit parameters.
>   

--
This message was sent by Atlassian Jira
(v8.3.4#803005)