[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127675#comment-17127675 ]

Jacques Le Roux commented on OFBIZ-11745:
-----------------------------------------

Hi Olivier,

More about my comment above.

What I see with "git diff" is
{noformat}
diff --git a/plugins b/plugins
index 2c65f7d17b..b08fa4a944 160000
--- a/plugins
+++ b/plugins
@@ -1 +1 @@
-Subproject commit 2c65f7d17bcdbccd7d166701365c56bca40d2f2d
+Subproject commit b08fa4a9441f4f67b210b29ef424f0eaf6ff0433-dirty
{noformat}

I never declared the plugins a submodule, and I have no pending change. So I looked for an answer and found several commits done for OFBIZ-8459 where plugins what successively added, reverted and added again:
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b39c179
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3a4d22
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bda6192

I have removed it locally (committed but not pushed it yet) and that should clear my concern. I'll ask on dev ML before pushing...

> plugins in common-theme/webapp/common/js is not monitored by git
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-11745
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11745
>             Project: OFBiz
>          Issue Type: Bug
>          Components: git
>    Affects Versions: Trunk
>            Reporter: Olivier Heintz
>            Assignee: Olivier Heintz
>            Priority: Major
>             Fix For: Trunk
>
>
> in .gitignore in root ofbiz directory there is plugins/
> so all directory plugins are ignored
> if the line is replace by plugins/* only root directory plugins is ignored

--
This message was sent by Atlassian Jira
(v8.3.4#803005)