[jira] [Commented] (OFBIZ-11747) Enforce noninstantiability to LoginWorker Class

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11747) Enforce noninstantiability to LoginWorker Class

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127517#comment-17127517 ]

ASF subversion and git services commented on OFBIZ-11747:
---------------------------------------------------------

Commit 9c447f248699e5942bc3b4c2ce4cb94d088fdf95 in ofbiz-plugins's branch refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=9c447f2 ]

Improved: Enforce noninstantiability to LdapLoginWorker, OFBizSolrLoginWorker class. (#23)

(OFBIZ-11747)

Made class as final, added private constructor and made static variables as private.

> Enforce noninstantiability to LoginWorker Class
> -----------------------------------------------
>
>                 Key: OFBIZ-11747
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11747
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>
> - Make LoginWorker class as final.
>  - Add a private constructor.
>  - Make the following public static variable as private and correct naming convention
> {code:java}
> public final static String MODULE = LoginWorker.class.getName();
> public static final String resourceWebapp = "SecurityextUiLabels";
> public static final String X509_CERT_ATTR = "SSLx509Cert";
> public static final String securityProperties = "security.properties";{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)